Skip to content

eng: drop Darwin amd64 devscript and FIPS builders - #2719

Merged
Quim Muntal (qmuntal) merged 5 commits into
microsoft/mainfrom
dev/qmuntal/darwin-pr-matrix
Nov 12, 2026
Merged

Quim Muntal (qmuntal) merged 5 commits into
microsoft/mainfrom
dev/qmuntal/darwin-pr-matrix

Conversation

@qmuntal

Copy link
Copy Markdown
Member

Summary

Remove the Darwin amd64 devscript and FIPS test builders from the shared matrix to reduce repeated full-suite work on slow Intel hosts.

  • Keep native baseline, nosystemcrypto, nocgo, and build-and-pack coverage.
  • Keep all five Darwin arm64 test configurations; Linux and Windows are unchanged.
  • Use the same policy for PR and rolling pipelines, with no PR-specific flag and no relocation to outerloop.

This deliberately drops Intel-specific devscript and FIPS lanes; those Darwin configurations remain covered on arm64.

Validation

  • Pipeline generator regression and reproducibility tests passed.
  • Locally checked all 16 matrix-flag combinations: only the two intended lanes are removed.
  • git diff --check passed.

Hosted Azure DevOps validation is pending.

Remove the Darwin amd64 devscript and FIPS test builders from the shared
matrix to reduce repeated full-suite work on slow Intel hosts. Keep the
baseline, nosystemcrypto, and nocgo builders, and retain all five Darwin
arm64 configurations.

Apply the same matrix to PR and rolling pipelines without introducing
PR-specific configuration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@qmuntal
Quim Muntal (qmuntal) marked this pull request as ready for review November 11, 2026 13:26
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner November 11, 2026 13:26
Copilot AI balanced review requested due to automatic review settings November 11, 2026 13:26
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change reducing redundant Darwin amd64 CI runs.

No open issues 🎉

What changed in this PR

Removes Darwin amd64 devscript and FIPS test builders from the shared CI matrix to reduce repeated full-suite runs on slow Intel hosts.

Changes:

  • Applies the same reduction to PR and rolling pipelines, without moving the removed lanes to outerloop.
  • Preserves Darwin amd64 baseline, nosystemcrypto, nocgo, and build-and-pack coverage; Darwin arm64, Linux, and Windows coverage remains unchanged.
  • Documents the Darwin coverage policy.
File Description
eng/​pipeline/​stages/​go-builder-matrix-stages.yml Removes the Darwin amd64 devscript and FIPS test lanes.
eng/​pipeline/​README.md Documents retained Intel coverage and arm64-only Darwin devscript and FIPS coverage.

Review effort: Balanced

@gdams

Copy link
Copy Markdown
Member

perhaps we should comment them out with a description of why we're skipping? Alternatively we could run this on an arm64 based mac using Rosetta?

Keep the devscript and FIPS entries commented out with the reason for
skipping them, as suggested in review of #2719. The active matrix is
unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qmuntal

Quim Muntal (qmuntal) commented Nov 11, 2026 •

Copy link
Copy Markdown
Member Author

I'll comment them out. The removed builders are not adding meaningful coverage. FIPS mode doesn't change anything on darwin, and nobody develops on darwin/amd64 these days.

Group the disabled devscript and FIPS builders together and explain why
these configurations are not needed on Darwin amd64.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) merged commit f588b8c into microsoft/main Nov 12, 2026
74 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the dev/qmuntal/darwin-pr-matrix branch November 12, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants