Repository navigation
eng: drop Darwin amd64 devscript and FIPS builders - #2719
Merged
Quim Muntal (qmuntal) merged 5 commits intoNov 12, 2026
Merged
Conversation
Remove the Darwin amd64 devscript and FIPS test builders from the shared matrix to reduce repeated full-suite work on slow Intel hosts. Keep the baseline, nosystemcrypto, and nocgo builders, and retain all five Darwin arm64 configurations. Apply the same matrix to PR and rolling pipelines without introducing PR-specific configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change reducing redundant Darwin amd64 CI runs.
No open issues 🎉
What changed in this PR
Removes Darwin amd64 devscript and FIPS test builders from the shared CI matrix to reduce repeated full-suite runs on slow Intel hosts.
Changes:
- Applies the same reduction to PR and rolling pipelines, without moving the removed lanes to outerloop.
- Preserves Darwin amd64 baseline, nosystemcrypto, nocgo, and build-and-pack coverage; Darwin arm64, Linux, and Windows coverage remains unchanged.
- Documents the Darwin coverage policy.
| File | Description |
|---|---|
eng/pipeline/stages/go-builder-matrix-stages.yml |
Removes the Darwin amd64 devscript and FIPS test lanes. |
eng/pipeline/README.md |
Documents retained Intel coverage and arm64-only Darwin devscript and FIPS coverage. |
Review effort: Balanced
Quim Muntal (qmuntal)
enabled auto-merge
November 11, 2026 13:28
Member
|
perhaps we should comment them out with a description of why we're skipping? Alternatively we could run this on an arm64 based mac using Rosetta? |
Keep the devscript and FIPS entries commented out with the reason for skipping them, as suggested in review of #2719. The active matrix is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
I'll comment them out. The removed builders are not adding meaningful coverage. FIPS mode doesn't change anything on darwin, and nobody develops on darwin/amd64 these days. |
Group the disabled devscript and FIPS builders together and explain why these configurations are not needed on Darwin amd64. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
George Adams (gdams)
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the Darwin amd64 devscript and FIPS test builders from the shared matrix to reduce repeated full-suite work on slow Intel hosts.
This deliberately drops Intel-specific devscript and FIPS lanes; those Darwin configurations remain covered on arm64.
Validation
git diff --checkpassed.Hosted Azure DevOps validation is pending.